😘

[Zzull]

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L5 Why aren't you copying the JSON file and working destructively with it instead of the one provided?

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L14 This should me "email" end not "mail" (which means postal mail)

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L24 I don't see why one would have to edit the requirements if they are just contributing to the project

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L31 Why is it called LOGIN and not EMAIL?

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L34 Why aren't they parameterized the same way APP_PASSWORD and LOGIN are? It's simpler to edit (only) a configuration file than code directly. This comment applies to the attachments and the path to the JSON file.

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L37 Maybe the attachments should be optional and not mandatory

[Ptiful]

ah stylé, je savais pas que tu pouvais des comments comme ça :) t'en penses quoi sinon ?

Le mer. 12 juin 2024 à 14:51, Baptiste Strazzulla @.***> a écrit :

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L5 Why aren't you copying the JSON file and working destructively with it instead of the one provided?

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L14 This should me "email" end not "mail" (which means postal mail)

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L24 I don't see why one would have to edit the requirements if they are just contributing to the project

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L31 Why is it called LOGIN and not EMAIL?

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L34 Why aren't they parameterized the same way APP_PASSWORD and LOGIN are? It's simpler to edit (only) a configuration file than code directly. This comment applies to the attachments and the path to the JSON file.

https://github.com/Ptiful/automatic_mail_sender/blob/03437d02c59260d4cd0ebbb86058a1163c0e68d4/README.md?plain=1#L37 Maybe the attachments should be optional and not mandatory

— Reply to this email directly, view it on GitHub https://github.com/Ptiful/automatic_mail_sender/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/APYQW7I2WAWGRUH6CKYZGXLZHA74DAVCNFSM6AAAAABJGJRFW2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DQNRZHAYTIMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Sent with Gmail for Sidekick Browser

[Zzull]

C'est pas du tout standard comme manière de commenter du code. Normalement, ça se fait à travers une MR. J'en pense sinon que c'est cool et que tu te démerdes bien !