Enhancements to be made

[PidgeyL]

Hey,

I really like what you've done with this, but there would be several enhancements I'd like to make. Though I would like to check first, if you are fine with them. Here's a small list of things I'd like to do:

• Change all the print statements with a custom logging statement. This way, you could write to a file, print to the screen, and so on, and your code becomes more readable and when changes need to happen, you need to change it in only one place
• Make a library to handle python 2 and 3 compatibility. Same reason as above - Done
• Change cfg.py, to use a configuration reader instead, with a .ini file, in an ./etc folder
• Add a way to feed the tool a script-readable source to automate things (makes things easier in a work environment, where less skilled people need to use it)

I'd like to change some parts to follow more of a standard, that makes teamwork and maintenance easier.

Let me know what you think

[Ptr32Void]

Hi,

Thanks for your interest. I have plenty of ideas and things I would like to add to the code. I think that almost all the things you want to do are doable and are a good enhancement to the tool. As you can see the code is a little bit messy and not really clear because I had to develop it as quickly as possible without much attention to details. If we want to go down that way we should review better the code and make decide how to proceed.

I like to have someone to help me out with this. But before going down with new pull requests I would like to discuss further via email/chat. What do you think?

Thanks.

[PidgeyL]

Sounds perfect! I'd propose to use gitter.im, which integrates perfectly with GitHub, and keeps track of the chats, so if people want to join, later on, they can read up on what has been discussed.

[Ptr32Void]

Sure. I will give you more details ASAP. I have few things to work on first.

[Ptr32Void]

I thought a little bit more about porting the system to Python 3; and I think that it is better to keep the system developed only on Python 2.7. I do not want too many "if" statements, different libraries and so on. I prefer to keep it simple.

Thanks.

[PidgeyL]

Okay, I'll just keep it in my fork then

[PidgeyL]

On second thought, maintaining a separate fork, where I'd do a lot of internal restructuring, while maintaining the upstream functionality in two languages, I'm not going to do this. As I'd like to add a lot of functionalities as well, I'll create a spin-off project. Of course, credit where credit is due, I'll reference this project in the readme :)

[Ptr32Void]

Sure, you can do it. But, I think that it would be a waste of effort since a project is already here and ready to go. My only issue is to keep the code clean and avoid adding Python 3. If you think that you can't add enhancement on the code by leaving Python 2.7, there is no problem, You can go ahead with it otherswise let me know and let's see what we can do.

Thanks for the effort.