Closed y2468101216 closed 3 years ago
Merging #227 (96c2424) into development (7e301b4) will decrease coverage by
0.61%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## development #227 +/- ##
===============================================
- Coverage 48.29% 47.67% -0.62%
===============================================
Files 28 28
Lines 1404 1422 +18
===============================================
Hits 678 678
- Misses 629 647 +18
Partials 97 97
Impacted Files | Coverage Δ | |
---|---|---|
internal/delivery/http/route_users.go | 44.07% <0.00%> (-5.10%) |
:arrow_down: |
internal/repository/repository.go | 0.00% <ø> (ø) |
|
internal/repository/user.go | 2.27% <0.00%> (+0.42%) |
:arrow_up: |
internal/usecase/usecase.go | 100.00% <ø> (ø) |
|
internal/usecase/user.go | 51.72% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e301b4...96c2424. Read the comment docs.
LGTM
這應該是修正 GET {{url}}/v1/users/{{user_id}}/comments
?
我看了一下我是把文章修好了,但是推文沒修好,我正在研究
看起來應該是不知道那次文章被修好了,推文部份我嘗試很久修不好,應該是要修 go-bbs 那邊實做的問題
看起來應該是不知道那次文章被修好了,推文部份我嘗試很久修不好,應該是要修 go-bbs 那邊實做的問題
看起來是 route_users.go 中的 getUserComments 最後回傳要修改。因為 dataItems 的 type 為 []bbs.UserCommentRecord,所以需要的回傳資訊可能要用 bbs.UserCommentRecord 所提供的 method 來取得。
responseMap := map[string]interface{}{
"data": map[string]interface{}{
"items": dataItems,
},
}
👏 解決掉的 issue / Resolved Issues
⛏ 變更內容 / Details of Changes
將 go-bbs 跟 ptt-backend 連結起來