Closed y2468101216 closed 3 years ago
Merging #233 (9f2b564) into development (84585bf) will increase coverage by
0.32%
. The diff coverage is11.11%
.
@@ Coverage Diff @@
## development #233 +/- ##
===============================================
+ Coverage 47.67% 48.00% +0.32%
===============================================
Files 28 28
Lines 1422 1504 +82
===============================================
+ Hits 678 722 +44
- Misses 647 682 +35
- Partials 97 100 +3
Impacted Files | Coverage Δ | |
---|---|---|
internal/usecase/board.go | 30.86% <0.00%> (+3.08%) |
:arrow_up: |
internal/usecase/usecase.go | 100.00% <ø> (ø) |
|
internal/delivery/http/route_users.go | 39.15% <12.00%> (-4.92%) |
:arrow_down: |
internal/delivery/http/route_classes.go | 40.47% <0.00%> (-14.37%) |
:arrow_down: |
internal/usecase/article.go | 28.20% <0.00%> (-0.75%) |
:arrow_down: |
internal/usecase/token.go | 0.00% <0.00%> (ø) |
|
internal/delivery/http/route_append_comment.go | 79.10% <0.00%> (+5.03%) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 84585bf...9f2b564. Read the comment docs.
https://github.com/Ptt-official-app/go-bbs/issues/86 這邊寫說不實做推文部份?
他應該是寫未實作而不是不實作?
目前未實做沒錯,我只有串上去而已
修正 utf8 編碼前
修正 utf8 編碼後
回傳資料應該要像是下圖?可能需要用 board_id 搭配 filename 來取得所屬文章的相關資訊。
👏 解決掉的 issue / Resolved Issues
⛏ 變更內容 / Details of Changes
修正了同一位使用者取不到推文問題
另外發現 go-bbs 只會回傳月日,不會回傳年分,這部分需另開 issue 做討論