Ptt-official-app / Ptt-backend

PTT APP 的後端
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

add route for update usefulness #234

Closed wagaru closed 3 years ago

wagaru commented 3 years ago

👏 解決掉的 issue / Resolved Issues

📝 相關的 issue / Related Issues

⛏ 變更內容 / Details of Changes

目前程式直接判斷 appendType == "↑",有需改成用 unicode 表示嗎?像是 appendType == "\u2191"

codecov-commenter commented 3 years ago

Codecov Report

Merging #234 (2376653) into development (84585bf) will increase coverage by 0.44%. The diff coverage is 91.30%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #234      +/-   ##
===============================================
+ Coverage        47.67%   48.11%   +0.44%     
===============================================
  Files               28       28              
  Lines             1422     1436      +14     
===============================================
+ Hits               678      691      +13     
- Misses             647      648       +1     
  Partials            97       97              
Impacted Files Coverage Δ
internal/usecase/article.go 28.20% <0.00%> (-0.75%) :arrow_down:
internal/usecase/usecase.go 100.00% <ø> (ø)
internal/delivery/http/route_append_comment.go 79.10% <95.45%> (+5.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84585bf...2376653. Read the comment docs.

PichuChen commented 3 years ago

用 \x 的hex表示可讀性會比較低,也比較可能出錯,未來方向可能有兩種,另外一種是用變數來代表,另一種是寫到設定檔裡

y2468101216 commented 3 years ago

LGTM