search

Ptt-official-app / Ptt-backend

PTT APP 的後端
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

convert boolean to string and add check permission #243

Closed whitefloor closed 3 years ago

whitefloor commented 3 years ago

👏 解決掉的 issue / Resolved Issues

📝 相關的 issue / Related Issues

⛏ 變更內容 / Details of Changes

codecov-commenter commented 3 years ago

Codecov Report

Merging #243 (928ed74) into development (f7c8dbc) will decrease coverage by 0.26%. The diff coverage is 74.19%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #243      +/-   ##
===============================================
- Coverage        47.88%   47.62%   -0.27%     
===============================================
  Files               28       28              
  Lines             1443     1451       +8     
===============================================
  Hits               691      691              
- Misses             655      663       +8     
  Partials            97       97
Impacted Files Coverage Δ
internal/usecase/token.go 0.00% <0.00%> (ø)
internal/delivery/http/route_boards.go 56.00% <100.00%> (ø)
internal/repository/user.go 2.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7c8dbc...928ed74. Read the comment docs.

PichuChen commented 3 years ago

@whitefloor 看起來應該是沒問題，不過你可以幫我附一張執行後的截圖嗎？

whitefloor commented 3 years ago

@PichuChen

截圖 2021-06-27 下午5 04 22
PichuChen commented 3 years ago

LGTM

y2468101216 commented 3 years ago

LGTM