search

Ptt-official-app / Ptt-backend

PTT APP 的後端
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

增加新增看板的錯誤回傳 #248

Closed whitefloor closed 3 years ago

whitefloor commented 3 years ago

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

PichuChen commented 3 years ago

Error 的部分可以統一放到 errors.go

codecov-commenter commented 3 years ago

Codecov Report

Merging #248 (1d446d2) into development (7866d2c) will increase coverage by 0.18%. The diff coverage is 77.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #248      +/-   ##
===============================================
+ Coverage        45.36%   45.55%   +0.18%     
===============================================
  Files               29       29              
  Lines             1609     1618       +9     
===============================================
+ Hits               730      737       +7     
- Misses             778      779       +1     
- Partials           101      102       +1
Impacted Files Coverage Δ
internal/delivery/http/route.go 50.28% <50.00%> (-0.01%) :arrow_down:
internal/delivery/http/errors.go 27.77% <100.00%> (+11.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7866d2c...1d446d2. Read the comment docs.

whitefloor commented 3 years ago
截圖 2021-07-11 下午9 08 06

@PichuChen 可以請問這是伺服器的測試資料對不上報錯嗎？ 我pull最新的development下來push的

PichuChen commented 3 years ago

@whitefloor 不好意思，是我上次的commit不小心忘記檢查lint，目前修好了，再請你幫忙merge conflicts