Ptt-official-app / Ptt-backend

PTT APP 的後端

BSD 3-Clause "New" or "Revised" License

208 stars 68 forks source link

加入Dockerfile並修正說明 #271

Closed karta0807913 closed 3 years ago

karta0807913 commented 3 years ago

👏 解決掉的 issue / Resolved Issues

close #269

⛏ 變更內容 / Details of Changes

加入 Dockerfile
變更 docker-compose.yml 加入 ptt-backend service
將 docker 與 docker-compose FOR_DEVELOPERS.md 加入建置環境說明
修改 FOR_DEVELOPERS.md 中的 Gofmt 套件為「必須」

PichuChen commented 3 years ago

這個是有把兩個的順序互調嗎？

karta0807913 commented 3 years ago

@PichuChen 那兩個？

PichuChen commented 3 years ago

FOR_DEVELOPERS.md 的

codecov-commenter commented 3 years ago

Codecov Report

Merging #271 (603f72e) into development (d66a810) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #271   +/-   ##
============================================
  Coverage        44.49%   44.49%           
============================================
  Files               29       29           
  Lines             1661     1661           
============================================
  Hits               739      739           
  Misses             819      819           
  Partials           103      103

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d66a810...603f72e. Read the comment docs.

karta0807913 commented 3 years ago

請問你說的是 開發環境建置 與 安裝與設定 這兩個區塊嗎？我在這部份是把他們混在一起統整成 開發環境建置 並在下面加入小標題。我是覺得這樣比較好懂一點，還是我把它分開？

y2468101216 commented 3 years ago

我覺得沒啥大問題 LGTM

PichuChen commented 3 years ago

LGTM