Ptt-official-app / Ptt-backend

PTT APP 的後端
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

implement recommend_count_gt and recommend_count_lt in articles #290

Closed karta0807913 closed 2 years ago

karta0807913 commented 3 years ago

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

codecov-commenter commented 3 years ago

Codecov Report

Merging #290 (61ccb4a) into development (3e17e31) will increase coverage by 2.06%. The diff coverage is 91.78%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #290      +/-   ##
===============================================
+ Coverage        44.04%   46.11%   +2.06%     
===============================================
  Files               29       29              
  Lines             1712     1800      +88     
===============================================
+ Hits               754      830      +76     
- Misses             848      857       +9     
- Partials           110      113       +3     
Impacted Files Coverage Δ
internal/usecase/board.go 33.33% <ø> (ø)
internal/delivery/http/route_boards_articles.go 75.00% <91.17%> (+32.69%) :arrow_up:
internal/delivery/http/errors.go 40.38% <100.00%> (+16.98%) :arrow_up:
internal/delivery/http/route_append_comment.go 71.62% <0.00%> (-7.49%) :arrow_down:
internal/config/config.go 77.27% <0.00%> (ø)
internal/repository/article.go 0.00% <0.00%> (ø)
internal/delivery/http/route_create_article.go 48.38% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e17e31...61ccb4a. Read the comment docs.

y2468101216 commented 2 years ago

@PichuChen @nickyanggg 請幫忙 review

y2468101216 commented 2 years ago

LGTM

karta0807913 commented 2 years ago

因為之前的寫法(使用匿名函數)似乎可讀性較差,所以將其整個重寫成可復用的結構(URLValuesParser) 還請各位幫我看看這樣是不是更好閱讀了

y2468101216 commented 2 years ago

usecase 的地方要改,然後我看重寫的部份沒啥問題

karta0807913 commented 2 years ago

usecase 的地方要改,然後我看重寫的部份沒啥問題

已修正