search

Ptt-official-app / Ptt-iOS

37 stars 7 forks source link

Add keychain #50

Closed xxi511 closed 1 year ago

xxi511 commented 1 year ago

Unit Test 部分，若升級上了 Xcode 13，則會因為 Texture 框架的問題，暫時無法跑測試（官方尚未 approve 可用的解法）https://github.com/TextureGroup/Texture/issues/2029

denkeni commented 1 year ago

KeychainSwift seems too trivial for this project, given the fact that we only need to store access_token, and we already have similar implementation. There's also little reason to store nonsecret information in Keychain, e.g. user_id and token_type.

Unit tests are great. What about writing tests for current implementation, mentioned above?

Texture upgrading is appreciated. Would you do it in another PR?

xxi511 commented 1 year ago

Ah...didn't know this class.

Well... since there is an existing object, there is no hurt to save a whole object.

Texture upgrading is appreciated. Would you do it in another PR?

sure , https://github.com/Ptt-official-app/Ptt-iOS/pull/52

xxi511 commented 1 year ago

Close, due to https://github.com/Ptt-official-app/Ptt-iOS/pull/53