search

PtyLab / PtyLab.py

Python implementation of ptylab
Other
18 stars 8 forks source link

changes from legacy `np.float` to `np.float32` #43

Closed ShantanuKodgirwar closed 1 year ago

ShantanuKodgirwar commented 1 year ago

It caused an error for python 3.10 when using the method ExperimentalData.showPtychogram, it fixed for me by replacing the legacy np.float to np.float32

roflmaostc commented 1 year ago

Any objections to merge @dboonz ?

How does versioning in Python work? Do we need to bump a numpy version?

dboonz commented 1 year ago

No! Go ahead :)

On July 14, 2023 4:15:06 PM GMT+02:00, roflmaostc @.***> wrote:

Any objections to merge @dboonz ?

How does versioning in Python work? Do we need to bump a numpy version?

-- Reply to this email directly or view it on GitHub: https://github.com/PtyLab/PtyLab.py/pull/43#issuecomment-1635927615 You are receiving this because you were mentioned.

Message ID: @.***> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

roflmaostc commented 1 year ago

Thanks!