Closed ShantanuKodgirwar closed 4 months ago
ready to merge?
yup!
However, it's better if PR #58 is merged before? Because this PR adds v0.1.3 and #58 adds v0.1.2 . Most likely, after either of the merge, it's likely I may need to resolve some merge conflicts first.
@roflmaostc Considering that PR #58 had a lot of changes (and if it is versioned to 0.2.0), this PR could be 0.1.2 and can be merged before? What do you think?
So merging this before?
yupp. The toml file here needs to be changed from 0.1.3 to 0.1.2 if you okay with it.
Yes, looks good. Change it and I merge :)
Thanks for your great work and sorry for that slowness.
No problem :) I understand that there aren't a lot of active python maintainers. Feel free to merge :)
This PR allows showing the update of reconstructions using the default inline backend of a jupyter (IPython) notebook. Previously, to observe the update of reconstructions within a notebook, one always required specifying an interactive backend such as qt5Agg or TkAgg, etc. Without an interactive backend, all you could see was the progress bar and not the live plots being updated with iterations. This can also be annoying if you are running a headless environment (remote server) and would like to use a jupyter notebook instead of a python script that requires X11 port forwarding for gui based interactive visualizations.
Summary of changes:
PtyLab/Monitor/Plots.py
, the backend is detected and if inline implements thedrawNowIpython
method for updating reconstructions.PtyLab/Monitor/Monitor.py
, some warning messages based on performance are specifiedjupyter_tutorials/jupyter_tutorials_tutorial_CPM_sim.ipynb
using the interactive as well as the non-interactive backend and also adds some minor changes to this notebook.ipykernel
is made as a compulsory dependency from optional because these new methods require them.PtyLab/Engines/BaseEngine.py
Note: Please merge PR https://github.com/PtyLab/PtyLab.py/pull/58 first as it adds the version 0.1.2
@roflmaostc @dboonz