Open aburt2 opened 1 year ago
Sure thing! We can talk more about that IRL today, but I plan to revisit the puara-gestures library next week. I plan to initialize the class with default internal variables (0.0 for the sensor data holders and gyroBuffers
), and implement a check on updateJabShake()
/ updateOrientation()
Also, there's some code cleaning to do.
We can push a quick fix today afternoon.
@aburt2 , I believe this is already fixed. Please let me know if not.
I'll leave this open for now.
Okay @edumeneses , I'll test this tomorrow
@edumeneses it is Still an issue with the latest T-Stick firmware
Thanks for taking the time to check. I'll add it to the lists to review in the code.
I started touching on that earlier this week.
I was testing with making a better sensor manager for the T-Stick (one that won't try to read from sensors that haven't responded) and while testing I've noticed that if you haven't set any gyroscope values using
setGyroscopeValues
and call theupdateInertialGestures()
method it causes the ESP32 to crash with the following error message.@edumeneses is it possible to have the function either print out a warning when the
gyroBuffers
are empty or initialise puara-gestures with zeros in thegyroBuffers
Tested on Tinypico with T-stick firmware (commenting out lines 420 - 426)