search

PubInv / NASA-COG

A control system for a highly reliable ceramic oxygen concentrator developed by NASA
GNU Affero General Public License v3.0
1 stars 3 forks source link

PID loop being used incorrectly.... #305

Closed RobertLRead closed 1 year ago

RobertLRead commented 1 year ago

In heater_pid_task.cpp at line 126, I am treating the output of the system as a delta instead of as the plant variable. @tomsrobots informs me this is wrong; I have always been uncertain about.

We agreed that this is too high risk to fix during the visit, but it will become the highest priority when we get home. I expect to fix it by October 3rd.

RobertLRead commented 1 year ago

This is now fixed in the develop.