PubInv / NASA-COG

A control system for a highly reliable ceramic oxygen concentrator developed by NASA
GNU Affero General Public License v3.0
1 stars 3 forks source link

Non Unique Reference Designators on Control V1.1 Morning of 20231012 #336

Closed ForrestErickson closed 11 months ago

ForrestErickson commented 11 months ago

Examining the schematic first page I see significant repetition of component reference designators. Reference designators must be unique before work can begin on the PCB.

@LokiMetaSmith Please resolve the reference designators to be unique. Ideally not changing any reference designators share with the V1 board.

Schematic Morning of 20231012

image

Schematic Evening of 20231011

This problem is not in the schematic as I pushed the branch last evening. image

Annotation Settings

During development of a schematic I may from time to time change the settings for annotating reference designators but here are my settings just now: image

LokiMetaSmith commented 11 months ago

This wasn't an issue when I pushed it last night. I'm investigating but I'm assuming at this point that you've introduced errors into your local repo.

[image: image.png]

On Thu, Oct 12, 2023 at 9:26 AM Forrest Lee Erickson < @.***> wrote:

Assigned #336 https://github.com/PubInv/NASA-COG/issues/336 to @LokiMetaSmith https://github.com/LokiMetaSmith.

— Reply to this email directly, view it on GitHub https://github.com/PubInv/NASA-COG/issues/336#event-10632384826, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGR5JHAYCVPVNXGQTH5XYDX674ZBAVCNFSM6AAAAAA55WYGHWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGYZTEMZYGQ4DENQ . You are receiving this because you were assigned.Message ID: @.***>

-- Lawrence Kincheloe Schedule a Meeting: (https://calendly.com/lawrence_kincheloe) Give me a call/text: (405) 255-7889 Co-Founder Juniper Garden LLC Co-Founder Splotch Creative

ForrestErickson commented 11 months ago

Note that there are 1Ohm resistors with a value of 1R and some with 1R0. image

The resistor with the value of 1R I had eliminated from the parts list and standardized on the 1R0 resistor as the fields on it were the more complete.

Here is the list Part List from last night showing zero 1R resistors. image

Please standardize on the 1R0 part.

ForrestErickson commented 11 months ago

View with Kicanvas.

https://kicanvas.org/?github=https%3A%2F%2Fgithub.com%2FPubInv%2FNASA-COG%2Fblob%2Fdevelop%2Felec%2FControl%2520Board%2FControl_1v1%2FControl_1v1%2FControl_1v1.kicad_sch

LokiMetaSmith commented 11 months ago

this is a rendering issue with kicanvas. I didn't change these and they look fine on the repo [image: image.png][image: image.png]

On Thu, Oct 12, 2023 at 9:42 AM Forrest Lee Erickson < @.***> wrote:

View with Kicanvas.

https://kicanvas.org/?github=https%3A%2F%2Fgithub.com%2FPubInv%2FNASA-COG%2Fblob%2Fdevelop%2Felec%2FControl%2520Board%2FControl_1v1%2FControl_1v1%2FControl_1v1.kicad_sch

— Reply to this email directly, view it on GitHub https://github.com/PubInv/NASA-COG/issues/336#issuecomment-1759749645, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGR5JEDLQICXNIDXQ6V3XLX676UDAVCNFSM6AAAAAA55WYGHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJZG42DSNRUGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Lawrence Kincheloe Schedule a Meeting: (https://calendly.com/lawrence_kincheloe) Give me a call/text: (405) 255-7889 Co-Founder Juniper Garden LLC Co-Founder Splotch Creative

LokiMetaSmith commented 11 months ago

the resistor reference values have been unified around 1R0 [image: image.png]

On Thu, Oct 12, 2023 at 9:51 AM Lawrence Kincheloe @.***> wrote:

this is a rendering issue with kicanvas. I didn't change these and they look fine on the repo [image: image.png][image: image.png]

On Thu, Oct 12, 2023 at 9:42 AM Forrest Lee Erickson < @.***> wrote:

View with Kicanvas.

https://kicanvas.org/?github=https%3A%2F%2Fgithub.com%2FPubInv%2FNASA-COG%2Fblob%2Fdevelop%2Felec%2FControl%2520Board%2FControl_1v1%2FControl_1v1%2FControl_1v1.kicad_sch

— Reply to this email directly, view it on GitHub https://github.com/PubInv/NASA-COG/issues/336#issuecomment-1759749645, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGR5JEDLQICXNIDXQ6V3XLX676UDAVCNFSM6AAAAAA55WYGHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJZG42DSNRUGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Lawrence Kincheloe Schedule a Meeting: (https://calendly.com/lawrence_kincheloe) Give me a call/text: (405) 255-7889 Co-Founder Juniper Garden LLC Co-Founder Splotch Creative

-- Lawrence Kincheloe Schedule a Meeting: (https://calendly.com/lawrence_kincheloe) Give me a call/text: (405) 255-7889 Co-Founder Juniper Garden LLC Co-Founder Splotch Creative

LokiMetaSmith commented 11 months ago

closing as this is complete, I pushed a bug report to kicanvas