PubInv / krake

A wireless alarm device which makes loud noises and flashes lights to alert a human
GNU Affero General Public License v3.0
0 stars 2 forks source link

Remove need to set serial numbers of device in code #73

Closed RobertLRead closed 3 days ago

RobertLRead commented 4 days ago

Is your feature request related to a problem? Please describe. At present, to use MQTT communication, you have to have correctly set the "topics" and the "Device under test" serial number in the code. This is error prone because after any commit made by another person, you have to carefully change these values.

Describe the solution you'd like I want the Serial number (and MQTT topics) of the device to be automatically set with no error-prone human intervention.

Describe alternatives you've considered We recommend using the MAC address built into each ESP32.

Additional context The MAC address is a 6 hexadecimal 2-digit numbers, representable by a 12-character string. It is easily obtainable in the code by using WiFi.macAddress().

RobertLRead commented 3 days ago

This was fixed in revision # 14.