Doesn't work at all with Zotero 5.0.97

[retorquere]

@brandonStell I've created a 5-0-97 branch that incorporates the necessary changes that makes the pubpeer plugin compatible with both 5.0.96.3 and 5.0.97. The incompatibility was announced here, and the requisite changes were announced here, but it took most plugin devs by surprise.

This new branch is untested, but the changes were minor in the end; you can see what changed by checkout out the branch and running git diff master.

I've also replaced webpack with esbuild -- sorry for not discussing, this, but for compatibility with both 5.0.96.3 and 5.0.97 I needed to exclude a require call from being usurped by webpack, and webpack has become unmanageably complex. Changing to esbuild was simpeler than figuring out webpack. esbuild is also massively faster.

[aidan-gibson]

Thank you so much, you're awesome!

Noob question, how can I compile this into a useable .xpi file?

[retorquere]

That is unchanged, just run npm run build. You'll have to run npm i once before that though, I updated the npm requirements.

[aidan-gibson]

Still no dice, unfortunately. I cloned that branch, used npm i and npm run build which generated the .xpi, but PubPeer doesn't work. I see it in the context menu "Check for comments on pubpeer" but no data propagates on the right side of zotero. If I can provide any further data please let me know.

The article I tried this on definitely had comments on pubpeer btw.

[retorquere]

The change was more meant to give the developers the start of Zotero 5.0.97 compat rather than a working fix (which is why I've committed on a branch rather than committing on master, but I'll see if it's an easy fix.

[retorquere]

The current state on the branch should work. I've done only minimal testing.

[champagnealexandre]

@retorquere thanks for the fix ; will it be committed on master soon? I’m currently running Zotero 5.0.97-beta.57+07df7d0de, the one on the dev build page on zotero.org

[retorquere]

The fix is already on master (and the 5-0-97 branch no longer exists); if you create a new version, a new release will be published automatically.

[champagnealexandre]

I’m sorry I don’t understand that last part of your message — creating a new version?

[retorquere]

If you issue npm version <level> in a clone of the repo , where level is major, minor or patch (see semver.org for what those levels mean) it will bump up the version number, and publish that version. After publishing, zotero of your users will start upgrading within 48 hours IIRC. Generally, if you're fixing a bug, that's a patch, if you're adding functionality but not incompatibly changing existing functionality, that's a minor, and if you have changes that are not backwards compatible, that's a major.

[champagnealexandre]

zotero of your users will start upgrading

still don’t understand what you mean, I don’t "have" any users ; I also don’t have any clone of the repo, I downloaded the dmg of the beta from zotero.org

by "committed on master soon" I meant will this be integrated in the publicly available dmg on zotero.org

[retorquere]

Oh sorry, I thought you were involved with development of this plugin. Then the answer to your question is "it is already committed on master"

[champagnealexandre]

No worries. So that means when the next updated dmg is available on zotero.org the fix will be included and the plugin will work?

[retorquere]

I don't follow? This isn't a fix to Zotero.

[champagnealexandre]

I thought that when you said "I've created a 5-0-97 branch" (first message of this issue) you were talking about a Zotero branch (because of the similarity in version number). I just came here because the plugin didn’t work — I’m a user, not part of any dev team related to Zotero or its plugins. That’s why I was wondering if there was a fix coming in for the end user. Sorry for the confusion.

[retorquere]

Ah, I see. No, this was the branch for the plugin for compatibility with Zotero 5.0.97