PubPeerFoundation / pubpeer_zotero_plugin

Plugin to show if references in Zotero have PubPeer comments
149 stars 2 forks source link

The enabled pubpeer plug-in affects the display of other plug-in settings. #44

Closed tcmtom closed 1 year ago

tcmtom commented 1 year ago

When the pubpeer plug-in is enabled, the setting items of these two plug-ins are not displayed in the setting box. This is the feedback under two plug-ins (Chinese): https://github.com/windingwind/zotero-pdf-translate/issues/393 https://github.com/MuiseDestiny/zotero-reference/issues/90

retorquere commented 1 year ago

Are you sure that it's pubpeer specifically? Pubpeer doesn't touch the prefs pane.

tcmtom commented 1 year ago

yes, I opened it one by one

tcmtom commented 1 year ago

1.zip You can watch my recording screen.

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 0.0.14.43 ("debug log sender")

Install in Zotero by downloading test build 0.0.14.43, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

retorquere commented 1 year ago

Can you:

You will get a popup with an alphanumeric string, please post that here.

tcmtom commented 1 year ago

Can you:

  • install build 43 just posted above
  • go into Help - Debug output logging - restart
  • Go Help - Send debug log to file.io

You will get a popup with an alphanumeric string, please post that here.

D331655264 Can you see?

retorquere commented 1 year ago

That is a zotero debug log. Please use the "send to file.io" option.

tcmtom commented 1 year ago

That is a zotero debug log. Please use the "send to file.io" option.

图片 B3Y9sGQGIjrQ-JXT9RF8G It should be this

retorquere commented 1 year ago

No errors in that log. Any one of zotero-pdf-translate and zotero-reference exhibits the problem?

tcmtom commented 1 year ago

该日志中没有错误。zotero-pdf-transit和zotero-reference中的任何一个都表现出问题?

Yes, when the pubpeer plugin is enabled, the setting items of these two plugins disappear in the settings.You can see it in the screen recording

tcmtom commented 1 year ago

https://github.com/MuiseDestiny/zotero-reference/issues/90#issuecomment-1467729852 Is this the reason?

retorquere commented 1 year ago

I can't read Chinese, so I can't tell. It seems to be because we use the DOM parser, if I comment that out, the prefs screen of the other plugin loads without issue.

The problem apparently is that Zotero has two XML DOM parsers built in; pubpeer uses nsiDOMParser, and it looks like pdf translate uses the other under some circumstances, and apparently that doesn't work. But it isn't immediately clear to me who should move here. Using nsiDOMParser is a valid approach, and while we could switch to the other domparser, that might mean pubpeer would break if someone else uses nsiDOMParser.

@windingwind, what is your take on this?

windingwind commented 1 year ago

I am also very confused with the DOMParser issue. I tended to report and discuss this in the dev group several days ago, while my mail address is banned in the dev group. According to the Zotero team, it is because Google recognizes me as an ad robot (which I am apparently not) and this happens to some other dev group users as well. They cannot do anything but wait until I am unblocked.

From my practice, the two DOMParser seem to have different behaviors and different compatibilities. Not sure which one we should use, but Zotero uses them both in their code. I also know there are some other related issues like the RSS doesn't work bug.

By any means, I guess this might be a bug with the Zotero side, as some failure with calling DOMParser should never cause the DOMParser itself unusable. Could you please report this to the dev group? I'm still waiting for Google to unblock me.

retorquere commented 1 year ago

while my mail address is banned in the dev group

that's stupid

Could you please report this to the dev group?

They'll want a reproducible minimal implementation -- I'm sorry, but I can't commit to that right now given my schedule. I'm using @xmldom anyhow for #38, I'll just see whether that can also be used for #44. It bloats the plugin a bit, but it is the path of least resistance towards a working situation.

windingwind commented 1 year ago

Hopefully, these annoying things will be gone in Zotero 7, which runs on FF 102 with a standard built-in DOMParser. I cannot wait to say goodbye to the nsiXXX things.

retorquere commented 1 year ago

I still have a looooong way to go before BBT is ready for 7. I finally have a prefs screen that I can load dynamically, which was the first step.

windingwind commented 1 year ago

Me tooooo. I am currently doing a total refactoring for the better notes plugin for Z7. Painful!

retorquere commented 1 year ago

I had already switched to xmldom for #38, so I've just issued a new release that bundles that change. Please upgrade to 0.0.16, that should resolve the issue.

tcmtom commented 1 year ago

image This issue no longer exists in version 0.0.16. Can the "send to file. io" be removed.

retorquere commented 1 year ago

Why would you want it removed?

tcmtom commented 1 year ago

I feel a bit redundant😂

retorquere commented 1 year ago

This is certainly not going to be the last issue that needs debugging. It's going to be relevant in the future.

tcmtom commented 1 year ago

Ok,thank you.