search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

Postcode #1

Closed jackhannah95 closed 4 years ago

jackhannah95 commented 4 years ago

Hi guys,

This is the (hopefully) completed first function for this package. It's for formatting a postcode into pc7 or pc8 format. If you could try to break it as much as possible, entering every combination of valid and nonsensical values you can think of and checking the output is as expected, that would be appreciated. Some feedback on the documentation would be good too, since theoretically anyone in PHI, regardless of R experience, should hopefully be able to follow it and use the function.

If no changes are requested, if you could all review separately before anyone merges that would also be appreciated. I think our reviews for these functions need to be as rigorous as possible if people are going to be using them out in the real world without our supervision.

Thanks!

jackhannah95 commented 4 years ago

Yeah we should take account of those. I'll make some changes.

jackhannah95 commented 4 years ago

Should be good to go now hopefully.