Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

Updated extract_fin_year. #121

Closed Nic-Chr closed 7 months ago

Nic-Chr commented 7 months ago

Hello, I have updated extract_fin_year() to apply the "YYYY/YY" format consistently. The calculations are now done using integer arithmetic and so should be faster and more memory efficient.

I've also added additional tests.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (63d6821) 97.41% compared to head (106aaa6) 97.40%. Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #121 +/- ## ========================================== - Coverage 97.41% 97.40% -0.01% ========================================== Files 13 13 Lines 425 424 -1 ========================================== - Hits 414 413 -1 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.