search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

Fix test for age_from_chi #125

Closed Tina815 closed 6 months ago

Tina815 commented 6 months ago

Some tests failed due to a helper function expected_age which makes the actual and expected age different when the new year comes. So it has been replaced with a fixed reference date.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0d02fbf) 97.40% compared to head (f5b8be2) 97.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ======================================= Coverage 97.40% 97.40% ======================================= Files 13 13 Lines 424 424 ======================================= Hits 413 413 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Moohan commented 6 months ago

Looks good, just waiting for the tests to pass. Do we need to increment the version number for this since it will be released on CRAN again?

E.g. https://readr.tidyverse.org/news/index.html#readr-214