search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

Fixes #21 #22

Closed davidc92 closed 4 years ago

davidc92 commented 4 years ago

I haven't changed much - just tweaked as suggested by @chrisdeans and also added the POSIXct class to the list of acceptable classes - this is the class that comes out of SMR and it's functionally the same (I think) so this removes the need to change the class. I added some tests too. This should be enough to fix #21, but let me know if there is anything else that should be added.

codecov-io commented 4 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         170    175    +5     
=====================================
+ Hits          170    175    +5
Impacted Files Coverage Δ
R/fin_year.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35c5b50...bf010b8. Read the comment docs.

davidc92 commented 4 years ago

This should be everything. :) Let me know if you spot anything else.

jackhannah95 commented 4 years ago

Hope it's alright that I added some stuff. Just wanted to get this done and merged today so I could do the 0.1.1 release.