Closed alice-hannah closed 4 years ago
As of dplyr v1.0.0, right_join() no longer sorts the rows of the output by the order of the RHS argument (see release notes).
right_join()
As a result, fin_year() no longer works as expected - see following reprex;
fin_year()
library(phsmethods) library(dplyr) library(lubridate) data <- tibble( dates = c(dmy(01012021), dmy(05011994), NA, dmy(01012021)) ) data %>% mutate(fy = fin_year(dates)) # A tibble: 4 x 2 # dates fy # <date> <chr> # 1 2021-01-01 2020/21 # 2 1994-01-05 2020/21 # 3 NA 1993/94 # 4 2021-01-01 NA/NA
I'll fix and open a pull request for this 👍 Thanks, Alice
As of dplyr v1.0.0,
right_join()
no longer sorts the rows of the output by the order of the RHS argument (see release notes).As a result,
fin_year()
no longer works as expected - see following reprex;I'll fix and open a pull request for this 👍 Thanks, Alice