search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

update to chi_check #38

Closed graemegowans closed 3 years ago

graemegowans commented 4 years ago

Hey guys,

@alan-y suggested an update to the chi_check function to return a more informative result on missing values (NAs). Would you be happy for me to make a branch for this?

Thanks,

Graeme

lucindalawrie commented 4 years ago

Hi Graeme,

This sounds like a good idea. Happy for a branch to be created 👍

Thanks, Lucinda

Moohan commented 3 years ago

Hey, any update on this? Looks like the pull request is has been reviewed and is ready to merge to me. Only outstanding change was first merge to the latest, which @graemegowans did on 22 June.

Just asking as my pull request #41 is queued up behind this one 😛