chi_check - message for missing values

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)

https://public-health-scotland.github.io/phsmethods/

54 stars 13 forks source link

chi_check - message for missing values #39

Closed graemegowans closed 3 years ago

graemegowans commented 4 years ago

Hi everyone, here are the changes to chi_check() to give a more useful message on missing values. I updated the tests and documents, but had problems with knitting readme.rmd (I think it's the error about the badges) - so I wasn't able to attach the .md version. I added @alan-y to the description file as it was his idea and he helped with code. Any changes let me know!

Thanks,

Graeme

graemegowans commented 4 years ago

Thanks @davidc92, sorry about that! You are right - I had made the branch before the other changes were merged. I pulled the latest version and merged into my branch - looks like everything is ok now and @jackhannah95's changes are there but let me know if there are any problems.

Thanks!