search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

Chi speed up #40

Closed Moohan closed 3 years ago

Moohan commented 4 years ago

I've been using the CHI functions quite a lot really so I pulled them apart with microbenchmark to try and eek some more performance out of them. Everything still seems to test as expected but is now just a bit faster!

davidc92 commented 4 years ago

Hi James

Can you please take a look at the contribution rules in the readme? First open an issue for approval before opening a PR. Might also be worthwhile providing some comparisons :)

Thanks

David

Moohan commented 4 years ago

See linked issue for comparisons, correct reviewers added this time ;)