search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

file_size masks function from fs #46

Closed Moohan closed 3 years ago

Moohan commented 3 years ago

file_size is masking file_size from fs. fs is not core tidyverse but is included so would be ideal if it wasn't masked.

I think the simplest solution would be to just rename the function when dealing with issue #11.

davidc92 commented 3 years ago

I don't think this is that big a deal - different packages having functions of the same name is pretty unavoidable. I don't think it's worth the effort bending over backwards trying to ensure that our function names are 100% unique, particularly to avoid masking something so obscure. Of course this would be different if we were masking something like mutate, but I'm content to just leave this as is. People can use :: if they really need to use both in the same script.