Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

qtr #6

Closed jackhannah95 closed 4 years ago

jackhannah95 commented 4 years ago

Hi Tina,

This is a small PR mainly to edit the error messages in the qtr functions if the input is something other than a date. Using the word 'format' is possibly a little ambiguous, as variables which are of the right format but the wrong class (such as a character variable with the format YYYY-MM-DD) won't work. I'm happy to be flexible on the exact phrasing, as long as the word "class" is in there and it's the same as the equivalent error message in @ciarag01's fin_year function.

I also added you and Ciara as authors in the description file.

Thanks!

jackhannah95 commented 4 years ago

Thanks - will do!