search

Public-Health-Scotland / phsmethods

An R package to standardise methods used in Public Health Scotland (https://public-health-scotland.github.io/phsmethods/)
https://public-health-scotland.github.io/phsmethods/
54 stars 13 forks source link

Remove gdata dependency #92

Closed Moohan closed 12 months ago

Moohan commented 1 year ago

Closes #91

Just a quick PR to remove the gdata dependency, as it's causing issues with installing phsmethods on the new server. I've replaced it with the scales package in the one place it was used, and tidied up the code a little bit.

terrymclaughlin commented 1 year ago

@rmccreath James McMahon has removed the dependency on {gdata} in the {phsmethods} package. Any idea who would be best placed to review this in Tina's absence?

Moohan commented 1 year ago

@terrymclaughlin / @rmccreath / @Tina815

I don't know if people are still having this issue?

Either way, I think scales is probably a better solution than gdata as it's more likely to already be installed by users (it's an r-lib package), and it solves the problem directly which makes the phsmethods code a bit neater.

If there's no rush for it this PR should probably be re-based to the development branch and just include with the next batch of changes.

rmccreath commented 1 year ago

If there's no rush for it this PR should probably be re-based to the development branch and just include with the next batch of changes.

Hey @Moohan - I'd say that the workaround for utilising {phsmethods} is known and your idea is the better solution for the package long term. I'm sure @Tina815 will be looking over this soon and can help get things sorted 😄

Moohan commented 12 months ago

Rebased to development in #98.