search

Public-Health-Scotland / phsopendata

Functions to extract and interact with data from the Scottish Health and Social Care Open Data platform.
https://public-health-scotland.github.io/phsopendata/
9 stars 3 forks source link

Review `{odns}` for inspiration #44

Open Moohan opened 2 days ago

Moohan commented 2 days ago

I was made aware of this package - https://github.com/jrh-dev/odns - written by @jrh-dev. It's not been updated in a while and I couldn't install it on the PHS Posit Workbench (possibly due to the R version). Still, it looks like it has some interesting features that are doing things differently to {phsopendata} in some cases.

I think it would be worth a review of the code which will probably generate a list of things to explore or add to this package in the future.

### Tasks
- [ ] Look at using `package_search` to allow finding only relevant data sets https://github.com/jrh-dev/odns/blob/main/R/all_packages.R
jrh-dev commented 2 days ago

Hey @Moohan , the package was previously on CRAN, it began failing in latest R versions and I haven't had time to maintain it. If it is useful, happy to pass ownership or collaborate.

Moohan commented 2 days ago

Hey James, the idea is to get phsopendata on CRAN in the near future. I'd be keen to hear anything you think is better about odns for us to try and replicate here though! We've quite a few features to phsopendata recently and there's probably been a lot of changes since you last looked at either package.

I just opened a PR to use httr::RETRY(#45). From a quick look, I also noticed you use package_search... I'm going to add a tasklist to my original comment which I think anyone can add to with interesting bits!