Elliebates - Githubissues

Public-Health-Scotland / phstemplates

Standard R templates and project structure for Public Health Scotland (https://public-health-scotland.github.io/phstemplates/)

Other

19 stars 6 forks source link

Elliebates #67

Closed elliejwbatesphs closed 1 year ago

elliejwbatesphs commented 1 year ago

Added MS Word management information templates which match to the Management Information one page, summary and report word templates

Minor errors in picking up publication title (summary) and publication subtitle (report) fixed.

The one page reference doc has been adapted slightly so it either matches the PHS One page management information template as on the spark, or, if additional pages are added, you can adapt it to use basic PHS styles for a 2 or more page document if you wish; second and following pages will have no page header and a PHS style footer with page number.

alan-y commented 1 year ago

I'll try to test this soon and if all works well, I'll approve and merge. I'll probably suggest incrementing the version as well since this is a new feature. Thanks.

alan-y commented 1 year ago

Hi @elliejwbatesphs - I've tested on RStudio desktop and POSIT Workbench, all looks good to me. Great work thanks! Could you do a few things on the package admin side please and then I'll approve?

in DESCRIPTION, feel free to add yourself as a co-author to the package.
in DESCRIPTION, please increment version to 1.1.1
update NEWS.md for the addition of these management info templates.

elliejwbatesphs commented 1 year ago

@alan-y - I've made the suggested amends / additions and push them to my branch, if you could check them, and let me know if there is anything additional you need me to do I'm presuming this pull request will just pick up the latest version of my elliebates branch but let me know if I need to do anything additional (I'm still a beginner to working jointly on code with others in git)