search

Public-Health-Scotland / source-linkage-files

This repo is for the syntax used for the PHS Source Linkage File project
https://public-health-scotland.github.io/source-linkage-files/
Other
4 stars 2 forks source link

Bug - Fix get pop path failing and preventing the indiv file from running. #913

Closed Jennit07 closed 9 months ago

Jennit07 commented 9 months ago

Found an issue which was preventing the individual file from running. I think this was missed on the PR #859 where the function works well but we forgot to apply this within the code. Tested the changes while looking at missing variables and it works fine now.

github-actions[bot] commented 9 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (4)

BOXI intzone popluation Rmarkdown

To accept these unrecognized words as correct, you could run the following commands ... in a clone of the [git@github.com:Public-Health-Scotland/source-linkage-files.git](https://github.com/Public-Health-Scotland/source-linkage-files.git) repository on the `bug-get_pop_path` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7904173051/attempts/1' ```

OR

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (235) from .github/actions/spelling/expect.txt and **unrecognized words** (4) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:swift/src/swift.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/swift/src/swift.txt)|53|1|| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|1|| [cspell:npm/dict/npm.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/npm/dict/npm.txt)|302|1|| [cspell:java/src/java-terms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java-terms.txt)|920|1|| [cspell:typescript/dict/typescript.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/typescript/dict/typescript.txt)|1098|1|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:swift/src/swift.txt cspell:filetypes/filetypes.txt cspell:npm/dict/npm.txt cspell:java/src/java-terms.txt cspell:typescript/dict/typescript.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
Pattern suggestions :scissors: (1) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 1 file-count: 1 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) ```
Errors (4) See the [:open_file_folder: files](https://github.com/Public-Health-Scotland/source-linkage-files/pull/913/files/) view, the [:scroll:action log](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7904173051/job/21573823546#step:4:1), or [:memo: job summary](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7904173051/attempts/1#summary-21573823546) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#candidate-pattern) | 1 [:x: check-file-path](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#check-file-path) | 1 [:x: ignored-expect-variant](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#ignored-expect-variant) | 13 [:information_source: no-newline-at-eof](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#no-newline-at-eof) | 1 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
github-actions[bot] commented 9 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (4)

BOXI intzone popluation Rmarkdown

To accept these unrecognized words as correct, you could run the following commands ... in a clone of the [git@github.com:Public-Health-Scotland/source-linkage-files.git](https://github.com/Public-Health-Scotland/source-linkage-files.git) repository on the `bug-get_pop_path` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7928345504/attempts/1' ```

OR

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (235) from .github/actions/spelling/expect.txt and **unrecognized words** (4) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:swift/src/swift.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/swift/src/swift.txt)|53|1|| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|1|| [cspell:npm/dict/npm.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/npm/dict/npm.txt)|302|1|| [cspell:java/src/java-terms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java-terms.txt)|920|1|| [cspell:typescript/dict/typescript.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/typescript/dict/typescript.txt)|1098|1|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:swift/src/swift.txt cspell:filetypes/filetypes.txt cspell:npm/dict/npm.txt cspell:java/src/java-terms.txt cspell:typescript/dict/typescript.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
Pattern suggestions :scissors: (1) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 1 file-count: 1 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) ```
Errors (4) See the [:open_file_folder: files](https://github.com/Public-Health-Scotland/source-linkage-files/pull/913/files/) view, the [:scroll:action log](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7928345504/job/21646416968#step:4:1), or [:memo: job summary](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7928345504/attempts/1#summary-21646416968) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#candidate-pattern) | 1 [:x: check-file-path](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#check-file-path) | 1 [:x: ignored-expect-variant](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#ignored-expect-variant) | 13 [:information_source: no-newline-at-eof](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#no-newline-at-eof) | 1 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.