search

Public-Health-Scotland / source-linkage-files

This repo is for the syntax used for the PHS Source Linkage File project
https://public-health-scotland.github.io/source-linkage-files/
Other
4 stars 2 forks source link

Reduce dependencies #984

Closed SwiftySalmon closed 1 month ago

SwiftySalmon commented 2 months ago

remove some packages from description file that don't get used anywhere

github-actions[bot] commented 2 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (12) ``` ADPE Canx CCYY CNWs Comhairle communicty LCHO Matern Mcbride PPAs rbindlist SMRA ```
Previously acknowledged words that are now absent adpe canx ccyy cnws comhairle lcho matern mcbride ppas returnsthe smra 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:Public-Health-Scotland/source-linkage-files.git](https://github.com/Public-Health-Scotland/source-linkage-files.git) repository on the `reduce_dependencies` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9977346486/attempts/1' ```

OR

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (307) from .github/actions/spelling/expect.txt and **unrecognized words** (12) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|3|3| [cspell:k8s/dict/k8s.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/k8s/dict/k8s.txt)|153|4|1| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|4|| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|3|1| [cspell:npm/dict/npm.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/npm/dict/npm.txt)|302|3|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:fullstack/dict/fullstack.txt cspell:k8s/dict/k8s.txt cspell:php/dict/php.txt cspell:node/dict/node.txt cspell:npm/dict/npm.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
Errors (1) See the [:open_file_folder: files](https://github.com/Public-Health-Scotland/source-linkage-files/pull/984/files/) view, the [:scroll:action log](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9977346486/job/27571730089#step:4:1), or [:memo: job summary](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9977346486/attempts/1#summary-27571730089) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:x: ignored-expect-variant](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#ignored-expect-variant) | 3 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
github-actions[bot] commented 1 month ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (15) ``` ADPE anomymous Canx CCYY CNWs Comhairle communicty datas LCHO Matern mcnicol megan PPAs rbindlist SMRA ```
Previously acknowledged words that are now absent adpe canx ccyy cnws comhairle lcho matern mcbride mcmahon ppas returnsthe smra 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:Public-Health-Scotland/source-linkage-files.git](https://github.com/Public-Health-Scotland/source-linkage-files.git) repository on the `reduce_dependencies` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/10469297653/attempts/1' ```

OR

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (307) from .github/actions/spelling/expect.txt and **unrecognized words** (15) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|3|3| [cspell:k8s/dict/k8s.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/k8s/dict/k8s.txt)|153|4|1| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|4|| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|3|1| [cspell:npm/dict/npm.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/npm/dict/npm.txt)|302|3|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:fullstack/dict/fullstack.txt cspell:k8s/dict/k8s.txt cspell:php/dict/php.txt cspell:node/dict/node.txt cspell:npm/dict/npm.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
Pattern suggestions :scissors: (1) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 3 file-count: 1 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) ```
Errors (2) See the [:open_file_folder: files](https://github.com/Public-Health-Scotland/source-linkage-files/pull/984/files/) view, the [:scroll:action log](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/10469297653/job/28992005451#step:4:1), or [:memo: job summary](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/10469297653/attempts/1#summary-28992005451) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#candidate-pattern) | 1 [:x: ignored-expect-variant](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#ignored-expect-variant) | 3 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
Jennit07 commented 1 month ago

@check-spelling-bot apply updates.

@check-spelling-bot apply updates.

github-actions[bot] commented 1 month ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (3)

pcs Postcodesio recordlinkage

To accept these unrecognized words as correct, you could run the following commands ... in a clone of the [git@github.com:Public-Health-Scotland/source-linkage-files.git](https://github.com/Public-Health-Scotland/source-linkage-files.git) repository on the `reduce_dependencies` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/10469690723/attempts/1' ```

OR

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (307) from .github/actions/spelling/expect.txt and **unrecognized words** (3) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|3|3| [cspell:k8s/dict/k8s.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/k8s/dict/k8s.txt)|153|4|1| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|4|| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|3|1| [cspell:npm/dict/npm.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/npm/dict/npm.txt)|302|3|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:fullstack/dict/fullstack.txt cspell:k8s/dict/k8s.txt cspell:php/dict/php.txt cspell:node/dict/node.txt cspell:npm/dict/npm.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
Pattern suggestions :scissors: (1) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 3 file-count: 1 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) ```
Errors (2) See the [:open_file_folder: files](https://github.com/Public-Health-Scotland/source-linkage-files/pull/984/files/) view, the [:scroll:action log](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/10469690723/job/28993268984#step:4:1), or [:memo: job summary](https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/10469690723/attempts/1#summary-28993268984) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#candidate-pattern) | 1 [:x: ignored-expect-variant](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#ignored-expect-variant) | 3 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
Jennit07 commented 1 month ago

@check-spelling-bot apply updates.

@check-spelling-bot apply updates.

github-actions[bot] commented 1 month ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:information_source: candidate-pattern 1
:x: ignored-expect-variant 3

See :x: Event descriptions for more information.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (307) from .github/actions/spelling/expect.txt and **unrecognized words** (0) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|3|3| [cspell:k8s/dict/k8s.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/k8s/dict/k8s.txt)|153|4|1| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|4|| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|3|1| [cspell:npm/dict/npm.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/npm/dict/npm.txt)|302|3|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:fullstack/dict/fullstack.txt cspell:k8s/dict/k8s.txt cspell:php/dict/php.txt cspell:node/dict/node.txt cspell:npm/dict/npm.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
Pattern suggestions :scissors: (1) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 3 file-count: 1 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) ```
Moohan commented 1 month ago

Hey, not sure why I've randomly received notifications about this PR :shrug:

I noticed you'd removed me and others from the DESCRIPTION - The usual practice is to have a single person as the 'package maintainer' they get the role cre (creator) - in the case of this package I put PHS as this which wouldn't be ok on CRAN but I think is fine...

For everyone else, small contributions would be 'contributor' ctb and bigger contributions should be 'authors' aut. People can have as many roles as required.

See the phsmethods DESCRIPTION and these docs - https://r-pkgs.org/description.html#sec-description-authors-at-r