Public-Tree-Map / public-tree-map-data-pipeline

Scripts to process open datasets for Public Tree Map (companion repository: https://github.com/Public-Tree-Map/public-tree-map). Work in progress:
https://publictreemap.org/
MIT License
8 stars 7 forks source link

Run Tests on PR Create/Update #94

Closed captainrandom closed 4 years ago

captainrandom commented 4 years ago

Motivation and context

This runs unit tests when a pull request is created and when a pull request is updated.

Something I probably should do is make the local python setup file use the requirements file as we are starting to get one too many setup scripts for python. (really just need one that works across the board)

Screenshots

Here is a url of the build working in my repo: https://github.com/captainrandom/public-tree-map-data-pipeline/runs/624873917?check_suite_focus=true

What I did

Keep in mind that only my script has unit tests being run on it. As other code is touched/added, we will add more unit tests to make sure that stuff is working.

captainrandom commented 4 years ago

You are going to have to enable the tests as part of the branch merge requirements. I can walk you through this next week.

emillipede commented 4 years ago

thank you @captainrandom !

Something I probably should do is make the local python setup file use the requirements file as we are starting to get one too many setup scripts for python. (really just need one that works across the board)

which requirements file do you mean? I agree about setup scripts. is it, for you, another argument to use containers?

captainrandom commented 4 years ago

Screen Shot 2020-05-04 at 7 26 10 PM

captainrandom commented 4 years ago

Screen Shot 2020-05-04 at 7 27 29 PM