Address bar update - Githubissues

Public-Tree-Map / public-tree-map

Public Tree Map documents all ~35,000 public street and park trees in Santa Monica's urban forest. The map includes contextual information collected from open datasets and digitized city records. To reflect tree plantings and removals, the map updates every day. We're also working to add tree data from other cities in LA county. Work in progress:

https://publictreemap.org

MIT License

43 stars 44 forks source link

Address bar update #285

Closed mrtmrt233 closed 4 years ago

mrtmrt233 commented 4 years ago

Implements update proposed here

Address bar now drops a pin at target location.

Map panning from one location to another is a bit off, might look into later. Current state seem publishable? @emillipede

emillipede commented 4 years ago

thank you @mrtmrt233 ! this looks great.

two questions:

is it possible to maintain something like the feature that shows a user's direction and/or adjusts the user's location marker as they walk down a street?
what do you mean about panning? I noticed that when I type an address into the search bar and click to move to it, the intended location winds up at the very bottom right corner of the page (off the visible screen)

thanks again!

mrtmrt233 commented 4 years ago

Yes, should be doable and yes that's what I'm referring to.

emillipede commented 4 years ago

Thank you! Maintaining a direction indicator and movement updates would be excellent.

mrtmrt233 commented 4 years ago

now uses leaflet.control.locate for current location.

emillipede commented 4 years ago

thank you @mrtmrt233 it's already a huge improvement.

a few more (new) questions:

can the marker track motion? It seems like it is built to do that now, but I tried to move around and couldn't get the marker to follow me or move at all
if motion tracking/following is an option, can the marker include a motion/direction indicator? something like the arrow in the screenshot above.
is it possible for a user to re-select the location sensor? eg if they zoom to their location, then pan away, and then want to zoom back to their location? I tried to re-click the icon, and it didn't respond. if I switch away from the tab, though, I'll get a new request to see my location

please let me know what you think. thanks again

mrtmrt233 commented 4 years ago

Location live tracking is on by default, but the arrow icon wasn't displayed. Fixed in latest push, along with refactoring and readability improvements.

Also fixed commit history

emillipede commented 4 years ago

thank you @mrtmrt233!

can you please share a screenshot? when I test the branch on a web browser, I can't get the arrow to show up

mrtmrt233 commented 4 years ago

Should be working... IMG_592C984FAA00-1

What's the testing setup when the arrow failed to show up? Did the browser prompt 2 requests for both location and motion & orientation?

emillipede commented 4 years ago

thank you @mrtmrt233

I didn't get the second prompt about motion and orientation. I test the branch by opening the index.html file in chrome or firefox. the screenshot looks great. I really appreciate your patience with my questions. I think this PR makes a big improvement to the site. thank you again.

mrtmrt233 commented 4 years ago

If the app is not used on mobile there's no motion & orientation functionality available I think

emillipede commented 4 years ago

thank you @mrtmrt233 !!