search

PublicaMundi / ckanext-publicamundi

PublicaMundi main CKAN extension
http://publicamundi.eu
Other
13 stars 12 forks source link

requests upgrade ok? #162

Open davidread opened 9 years ago

davidread commented 9 years ago

The requirements.txt specifies "requests==1.1.0" and on core CKAN we're looking to upgrade the requests version in the next CKAN release. We just want to make you aware so you can check compatibility - we've noticed minor things change, like the type of response.headers is not a dict, but a dict-like object. We're looking at requests version 2.3.0 or 2.7.0.

davidread commented 9 years ago

BTW the related ckan discussion is here: https://github.com/ckan/ckan/issues/2470

drmalex07 commented 9 years ago

Thanks @davidread. Currently, the ckanext-publicamundi extension is only compatible with CKAN 2.2 but, of course, we want to keep pace with new CKAN releases (#97). So i assume that porting our requests-depending code will be a part of this work.

davidread commented 9 years ago

Ok, great, I'll leave this with you then. Feel free to close this issue or keep it open, as you wish.

drmalex07 commented 9 years ago

Ok, we' ll keep it open as long as #97 is open (since it contains it)