search

PublicisSapient / enable-a11y

MIT License
11 stars 5 forks source link

feat: Adding icons next to headings to have summarized info #129

Closed shiprarawal closed 3 weeks ago

alisonhall commented 3 weeks ago

Hey @shiprarawal , do you think you could add some screenshots to this PR? I was also wondering if there's any way to optimize the code a bit so that we don't have as many nested loops. Otherwise it looks pretty good!

shiprarawal commented 3 weeks ago

Hi @alisonhall , Please find the screenshots below :

Screenshot 2024-06-07 at 10 08 59 AM Screenshot 2024-06-07 at 10 09 28 AM Screenshot 2024-06-07 at 10 09 39 AM

Let me take a look for code optimization. Thanks!

shiprarawal commented 3 weeks ago

Hi @alisonhall , I have updated the code . Please take a look.

alisonhall commented 3 weeks ago

@shiprarawal , this code is much simpler, thanks! I just added 2 minor comments/questions.

zoltan-dulac commented 3 weeks ago

I am okay with this as long as @alisonhall is. Please merge when you get @alisonhall 's approval.