search

PublicisSapient / enable-a11y

MIT License
11 stars 5 forks source link

feat: test cases for the Tab component #130

Closed mahesh0618 closed 2 weeks ago

zoltan-dulac commented 3 weeks ago

This is a good start. I would like the following added:

1) Do the selector fix outlined above. 2) I would also like to add in the unit test that the active tab always has aria-selected="true". 3) Ensure the DOM has the right structure. Take a look at the code walk-through on the Enable Tabs page. Steps #5-#9 in that walk-through will tell you what you should test for. (I should have outlined that to you before starting work that you should go through the code walk-throughs).

Let me know when this is done and I'll approve (I do want to run on my local to double check when I am done, but it looks like it works as it should.

mahesh0618 commented 3 weeks ago

@zoltan-dulac Feedback has been incorporated, please validate.

zoltan-dulac commented 3 weeks ago

Hi Mahesh! Good job so far. Just want a few more changes. After those are done, I think we can merge.