Reserved characters should not be percent-encoded

[ghost]

purell should not normalize reserved characters, as per RFC3986:

  reserved    = gen-delims / sub-delims

  gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"

  sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
              / "*" / "+" / "," / ";" / "="

package main

import (
    "fmt"

    "github.com/PuerkitoBio/purell"
)

func main() {
    fmt.Println(purell.MustNormalizeURLString("my_(url)", purell.FlagsSafe))
}

The above code outputs my_%28url%29, whereas it should be my_(url). This is due to a bug in Go stdlib (issue 5684).

[mna]

Totally agree, but as you mention, this is due to the parsing and escaping done by Go's stdlib. Once/if the bug is fixed in Go, this will be fixed too. Not a purell bug per se.

[ghost]

I believe that purell should use its own implementation of url.Parse/url.String and not rely on the buggy stdlib.

[mna]

Pull requests welcome.