Pugmatt / BedrockConnect

Join any Minecraft Bedrock Edition server IP on Xbox One, Nintendo Switch, and PS4/PS5
GNU General Public License v3.0
1.43k stars 165 forks source link

Bedrock 1.19.20 update #311

Closed dnsBlah closed 2 years ago

dnsBlah commented 2 years ago

What happened?

Unable to join 1.19.20 servers

Excepted Behaviour?

Expected to be able to join xD

Steps to reproduce.

Join the BedrockConnect instance

Screenshots/Videos

No response

Minecraft Bedrock Version

1.19.20

Console

Nintendo Switch

Additional Context

Can you please update the instance <3

kmpoppe commented 2 years ago

It'll take some time for the implemented protocol project to update and then going into BC. Just a little patience, the server just released today :-)

dnsBlah commented 2 years ago

I fully understand, unfortunately my daughter wants to play 🤣 She doesn't understand it :( iOS also upgraded 1hr ago x.x

Camotoy commented 2 years ago

Protocol is updated, but we did get a little blindsided by the timing of this update. I'll make a PR here to address this soon unless someone else gets around to it first.

zellyn commented 2 years ago

@kmpoppe would a PR be helpful, or are you all already fixing it? Looks like bumping the protocol library to 2.9.11-SNAPSHOT and changing the default version to 544 should do it, right?

Pugmatt commented 2 years ago

Working on it now. Thank you for your patience everyone.

Pugmatt commented 2 years ago

Was able to bump the Protocol version. Joins and displays form list without issue. Looks like an error occurs possibly from the Protocol library when trying to call getFormData() from the ModalFormResponsePacket after a button is clicked, the data appears corrupted. When printing/debugging it in the console, it appears empty or random characters.

[Network Listener - #3] WARN io.netty.util.concurrent.AbstractEventExecutor - A task raised an exception. Task: com.pyratron.pugmatt.protocol.bedrock.BedrockRakNetSessionListener$$Lambda$124/1559417428@1505c3a0
java.lang.NumberFormatException: For input string: ""
        at java.lang.NumberFormatException.forInputString(Unknown Source)
        at java.lang.Integer.parseInt(Unknown Source)
        at java.lang.Integer.parseInt(Unknown Source)
        at main.com.pyratron.pugmatt.bedrockconnect.listeners.PacketHandler.handle(PacketHandler.java:100)
        at com.pyratron.pugmatt.protocol.bedrock.packet.ModalFormResponsePacket.handle(ModalFormResponsePacket.java:22)
        at com.pyratron.pugmatt.protocol.bedrock.handler.DefaultBatchHandler.handle(DefaultBatchHandler.java:29)
        at com.pyratron.pugmatt.protocol.bedrock.BedrockSession.onWrappedPacket(BedrockSession.java:284)
        at com.pyratron.pugmatt.protocol.bedrock.BedrockRakNetSessionListener.lambda$onEncapsulated$0(BedrockRakNetSessionListener.java:39)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at java.lang.Thread.run(Unknown Source)

@Camotoy Not sure if you have any insight on this. I can post an issue in the Protocol repository as well so it's properly tracked, assuming this isn't a silly mistake on my end. Here's the current changes: https://github.com/Pugmatt/BedrockConnect/commit/93e91a83a8e2d64453898846d06f5615312e46bd

EDIT: Issue posted: https://github.com/CloudburstMC/Protocol/issues/167

Camotoy commented 2 years ago

Geyser is running into the same issue.

Camotoy commented 2 years ago

Fixed; it should require no changes on your end. Just a silly mistake.

jordan-da commented 2 years ago

You folks are legends, thank you so much getting on top of this as fast as you have. I don't think any of us expected this to drop today.

Pugmatt commented 2 years ago

Fixed; it should require no changes on your end. Just a silly mistake.

You're awesome, thank you 👍

The main BedrockConnect server has now been updated to 1.19.20. I'm seeing some other errors being thrown, but I don't believe it should be affecting players from what I'm seeing. Will continue to look into it, but players should be able to join and use it in the meantime.

EDIT: Looking at latest issue that was submitted it looks like there's some issues. Will try and fix this before releasing the JAR.

youforgottofollow commented 2 years ago

its working again thanks for fixing so fast

Pugmatt commented 2 years ago

Released the JAR for the new version. https://github.com/Pugmatt/BedrockConnect/releases/tag/1.21 Errors might still occur, but it should function for now to cover the new update, and players themselves shouldn't be experiencing issues from the errors. Will release a hot patch later for the possible errors.

dnsBlah commented 2 years ago

They've done it again! Much love guys!

Camotoy commented 1 year ago

We’re experiencing form issues as well. I’ll update here once we figure out what’s up.

On Aug 9, 2022, at 17:43, Mattie @.***> wrote:

 Was able to bump the Protocol version. Joins and displays form list without issue. Looks like an error occurs from the Protocol library when trying to call getFormData() from the ModalFormResponsePacket after a button is clicked, the data appears corrupted.

[Network Listener - #3] WARN io.netty.util.concurrent.AbstractEventExecutor - A task raised an exception. Task: @.*** java.lang.NumberFormatException: For input string: "" at java.lang.NumberFormatException.forInputString(Unknown Source) at java.lang.Integer.parseInt(Unknown Source) at java.lang.Integer.parseInt(Unknown Source) at main.com.pyratron.pugmatt.bedrockconnect.listeners.PacketHandler.handle(PacketHandler.java:101) at com.pyratron.pugmatt.protocol.bedrock.packet.ModalFormResponsePacket.handle(ModalFormResponsePacket.java:22) at com.pyratron.pugmatt.protocol.bedrock.handler.DefaultBatchHandler.handle(DefaultBatchHandler.java:29) at com.pyratron.pugmatt.protocol.bedrock.BedrockSession.onWrappedPacket(BedrockSession.java:284) at com.pyratron.pugmatt.protocol.bedrock.BedrockRakNetSessionListener.lambda$onEncapsulated$0(BedrockRakNetSessionListener.java:39) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at java.lang.Thread.run(Unknown Source) @Camotoy Not sure if you have any insight on this. I can post an issue in the Protocol repository as well so it's properly tracked, assuming this isn't a silly mistake on my end. Here's the current changes: 93e91a8

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.