Pugmatt / BedrockConnect

Join any Minecraft Bedrock Edition server IP on Xbox One, Nintendo Switch, and PS4/PS5
GNU General Public License v3.0
1.37k stars 160 forks source link

Domain name validation does not allow underscores #439

Closed KurtThiemann closed 10 months ago

KurtThiemann commented 10 months ago

What happened?

Trying to add a server with a hostname containing an underscore (_) results in the error message "Enter a valid address. (E.g. play.example.net, 172.16.254.1)".

Expected Behaviour?

Hostnames containing underscores should be accepted.

Steps to reproduce.

  1. Connect to a BedrockConnect instance
  2. Try adding a server with a hostname that contains an underscore (e.g. my_example.com)

Screenshots/Videos

No response

Minecraft Bedrock Version

1.20.14

Console

Nintendo Switch

Additional Context

While underscores in domain names are technically not allowed, they are widely used and work correctly when adding custom servers in Minecraft Bedrock Edition directly (on platforms that officially support custom servers).

KurtThiemann commented 10 months ago

Fixed in #440