search

Pull-Request-Community / pull-request-community-website

Pull request community
https://pullrequest.co.il/
MIT License
56 stars 100 forks source link

Feat enable ts strict mode #245

Closed Yedidyar closed 2 years ago

Yedidyar commented 2 years ago

this branch is extended feat-ceate-unit-test-for-randomShuffel

netlify[bot] commented 2 years ago

Deploy Preview for agitated-hoover-61371e ready!

Built without sensitive environment variables

Name Link
Latest commit f54f5b1b4e08341c703c41c1be88a3afea8d85bf
Latest deploy log https://app.netlify.com/sites/agitated-hoover-61371e/deploys/62c084572fdcc700089de29f
Deploy Preview https://deploy-preview-245--agitated-hoover-61371e.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Preview on netlify: https://deploy-preview-245--pull-request.netlify.app/

MichalPorag commented 2 years ago

@Yedidyar please fix conflicts

Yedidyar commented 2 years ago

@MichalPorag I resolved the merge conflicts.

MichalPorag commented 2 years ago

@Yedidyar Hi, I see that you made a lot of changes here. But, I am not sure this is the right time to enable TS strict mode to the project. I prefer doing it after this phase (renovating the website) because we are already in the middle. Also, I always prefer to upgrade libraries in separate PR to ensure nothing breaks. I'm closing the PR now, but let's talk about it privately.