Pull-Request-Community / pull-request-community-website

Pull request community
https://pullrequest.co.il/
MIT License
56 stars 100 forks source link

chore: run a test on the deployed netlify url #253

Closed lirantal closed 2 years ago

lirantal commented 2 years ago

WIP: experimenting with running Playwright on a PR's preview URL on Netlify

netlify[bot] commented 2 years ago

Deploy Preview for agitated-hoover-61371e ready!

Built without sensitive environment variables

Name Link
Latest commit 005a671293ea09ad7321985235acf7bed0ab20f0
Latest deploy log https://app.netlify.com/sites/agitated-hoover-61371e/deploys/6304fefdb39b360008db2430
Deploy Preview https://deploy-preview-253--agitated-hoover-61371e.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Preview on netlify: https://deploy-preview-253--pull-request.netlify.app/

MichalPorag commented 2 years ago

@lirantal can you please resolve conflicts?

lirantal commented 2 years ago

@MichalPorag resolved but it is probably going to need to resolve another time after you merge #249

MichalPorag commented 2 years ago

@lirantal can you please fix eslint text?

lirantal commented 2 years ago

@MichalPorag what is the actual issue that needs fixing? can't tell much from this, these are all set to warn.

image
lirantal commented 2 years ago

Also to note that when I run the linter check locally I get that everything's just fine:

npm run lint

> pull-request-community@0.1.0 lint
> next lint

info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
✔ No ESLint warnings or errors
lirantal commented 2 years ago

@MichalPorag ready to merge 🙏🏼

MichalPorag commented 2 years ago

Hi @lirantal, thank you so much. Unfortunately still can't merge, too many changes... Please open in new PR. Closing it for now.

lirantal commented 2 years ago

I think it was ok but anyway I'll open a new PR one you merge the other one then :-)