Closed dabdine closed 1 year ago
This update looks good and complete. Have you considered writing any unit tests? It's good that you're using interfaces for dependencies to make it easier to mock things out for tests.
Andy W
Reviewers will be notified any time you reply to their comments or commit new changes. You can also request a full follow-up review from your PullRequest dashboard.
Yep, I'll add some tests.
Adds embeddings. Tested it locally with a client I have to ensure it works.