Pullusb / storytools

Blender addon - Set of tool for storyboarding in Blender
GNU General Public License v3.0
71 stars 3 forks source link

Quick duplicating all keys to new frame #42

Closed nekrasovdmitriy closed 1 month ago

nekrasovdmitriy commented 1 month ago

Suggestion — one button creating new frame with all keys duplicated from existing frame (like it is done in Storyboarder — "duplicate board"). It is useful because as usual you have to add local edits in existing frame, not changing everything. Now i have to manually selecting all frames and shift-D + dragging in Dope Sheet, frustrating.

Pullusb commented 1 month ago

Hi, thank you for the feedback.

If you always want to keep previous frames drawing, you can toggle the additive draw

image

But I agree having dedicated single direct actions would be nice, instead of the check/uncheck -> then act workflow.

I wanted to implement an "Add GP key" button anyway (see #31) guess I should add a pair of two buttons instead.

Pullusb commented 1 month ago

Hello @nekrasovdmitriy,

"New GP frame" buttons have been freshly added in version 1.17.0 First button create empty keys, second duplicate previous, Ctrl + Click offset following keys. More details in changelog below

image

Closing the issue. If you have further suggestions or found a bug, feel free to reopen here or create a new issue if it seems more appropriate

1.17.0 changelog :

added: Extend the control bar with new Grease pencil operators buttons:

added: addon preferences Default Autolock Layers set autolock state on new Grease pencils (enabled by default)
added: addon preferences Default Layer Use Light to set Use light state on new created object (disabled by default)
added: addon preferences Grease Pencil Frame Offset interval when offsetting key at creation (if already on a key) or when applying offset to subsequent frames

nekrasovdmitriy commented 1 month ago

Big thanks! I will test the update

nekrasovdmitriy commented 1 month ago

Strange thing is that both buttons add 12 extra frames to each new key. Keying each frame is more logical, or add frames offset in settings.

Снимок экрана 2024-09-27 в 23 32 45

Pullusb commented 1 month ago

Hi. Yes, both buttons work the same way, just a choice: empty frame or copy frame.

The offset is intentional, and happen only if your cursor is on a key (on unlocked and visible layers). The frame offset setting exists, it's in addon-preferences for now. Maybe I'll add a more direct access to settings like this one, but not my priority ATM. About the offset size, I've seen that storyboard people typically use larger spacing, so I went with a default offset value of 12. You think it should be at 1 by default ?

Anyway, I will wait to have feedbacks after tests from multiple storyboard artists on this before changing anything.

nekrasovdmitriy commented 1 month ago

It is pretty frustrating to have different behaviour with cursor staying over current keyframe and not.

Typical workflow: drawing on current frame, ONE KEY PRESS and continue drawing on new clean frame with onion skin or ONE KEY PRESS and continue editing current frame duplicate. (this is how it works in Storyboarder). Now i have to press RIGHT to step one frame forward and only there press empty frame or copy frame if i do not need an offset.

Why offset is not handy? — when you boarding a movement wit a lot of keys, you have to jump between frames to check it, just pressing LEFT or RIGHT arrow. If you have in-betweens keys everywhere as default, it is not possible.

Pullusb commented 1 month ago

It is pretty frustrating to have different behaviour with cursor staying over current keyframe and not.

If you don't have an "on-key" specific behavior, Then you'll always have to press Right then add key.

So, just to be sure about the behavior you expect. If you set the frame offset in preference to 1 as mentioned in my previous message, is it not exactly as you want ?

prefs

nekrasovdmitriy commented 1 month ago

Yes, setting offset in preferences is handy, thanks.