Pulover / PuloversMacroCreator

Automation Utility - Recorder & Script Generator
http://www.macrocreator.com
Other
1.59k stars 231 forks source link

Relative Record Key "Toggle" option does not work #260

Open sfetrzak opened 12 months ago

sfetrzak commented 12 months ago

There is a bug in Recording.ahk in line 523/531 and 553/560 -> "ToggleMode" variable should be used instead of "Toggle"

ClickOn(xPos, yPos, Button, Click := "")
{
    global RelHold, LastPos, RelKey, ToggleMode
    If (RelHold = 1)
    {
        Loop, Parse, LastPos, /
            iPar%A_Index% := A_LoopField
        Relative := RelToLastPos(iPar1, iPar2, xPos, yPos)
    }
    LastPos := xPos "/" yPos
    If (GetKeyState(RelKey, ToggleMode))
    {
        xPos := "Rel 0"
        yPos := 0
        RelHold := 1
    }
    If (Relative != "")
        Details := Relative " " Button ", " Click
    Else
        Details := xPos ", " yPos " " Button ", " Click
    return Details
}

RelToLastPos(lX, lY, cX, cY)
{
    cX -= lX
    cY -= lY
    return "Rel " cX "`, " cY
}

MoveCheck()
{
    global MDelay, LastPos, RelKey, ToggleMode, CoordMouse
    CoordMode, Mouse, %CoordMouse%
    MouseGetPos, xPos, yPos
    If (LastPos = xPos "/" yPos)
        return
    If (A_TimeIdle < MDelay)
        return
    If (GetKeyState(RelKey, ToggleMode))
    {
        Loop, Parse, LastPos, /
            iPar%A_Index% := A_LoopField
        MovedPos := RelToLastPos(iPar1, iPar2, xPos, yPos)
    }
    Else
        MovedPos := xPos ", " yPos
    LastPos := xPos "/" yPos
    return MovedPos
}
WAZAAAAA0 commented 8 months ago

Thanks for the fix. Makes recording mouse movement in Relative mode easier. This should be merged.