Pulsar-Edit-Highlights / line

@Pulsar-Edit package for highlighting the currently selected line.
https://web.pulsar-edit.dev/packages/highlight-line
MIT License
52 stars 16 forks source link

Maintainer #104

Closed ElectronicsArchiver closed 1 year ago

ElectronicsArchiver commented 1 year ago

Was looking through my installed extension and wanted to contribute, checked out the repo page for your project and saw you were looking for someone to help you out, if you are still looking, I'd love to help.

ElectronicsArchiver commented 1 year ago

@richrace Thank you, I will get to work right away

richrace commented 1 year ago

Hi thanks!

I was wondering if you'd be up for taking on https://github.com/richrace/highlight-selected also?

ElectronicsArchiver commented 1 year ago

@richrace Sure, I planning on updating as many - now Pulsar - packages as possible!

Btw, I might have to disable ( and later redo ) CI since atom -> pulsar and apm -> ppm ( though I haven't been able to get ppm to work on my system yet .. )

ElectronicsArchiver commented 1 year ago

@richrace Btw, as a collaborator I sadly don't have the ability to adjust the following, which is why I'd like to ask of you to set them:

richrace commented 1 year ago

Hopefully this change will give you more freedom.

ElectronicsArchiver commented 1 year ago

@richrace Oh, well that works as well, thanks, I will adjust it myself then~

ElectronicsArchiver commented 1 year ago

Oh lol, I didn't even realize at first that you create an organization, while that is nice, now links will have to be updated as well.

( package repository and the like )

ElectronicsArchiver commented 1 year ago

@richrace Btw, I'm still in need of asking you to disable the projects / discussions tabs, I'm not able to fully disable them ..

richrace commented 1 year ago

Oh lol, I didn't even realize at first that you create an organization, while that is nice, now links will have to be updated as well.

( package repository and the like )

Sorry for that.

I’ve disabled discussions.

ElectronicsArchiver commented 1 year ago

No problem, to give you some more information on my progress:

While all tests still pass and the code should be fine,

ElectronicsArchiver commented 1 year ago

@richrace Since you moved the repositories to an org named

Pulsar-Edit-Highlights you could also rename the repositories and shorten their names.

ElectronicsArchiver commented 1 year ago

@richrace Made a .GitHub repository for the organization overview.

https://github.com/Pulsar-Edit-Highlights/.GitHub

Also, what do you think of this simple logo I made:

https://github.com/Pulsar-Edit-Highlights/.GitHub/blob/main/Avatar.svg

ElectronicsArchiver commented 1 year ago

@richrace In case the logo is good enough for now, I would add a png version that you could download and set as the organizations avatar .. let me know

Updates:

richrace commented 1 year ago

@ElectronicsArchiver the logo is great! Thanks.

ElectronicsArchiver commented 1 year ago

@richrace So, about publishing ..

( Only focused on the line repo for now )

  1. PPM works for me now

    It's installed when installing Pulsar from https://pulsar-edit.dev/docs/

  2. It needs a personal access token as you know

  3. Since you are the author listed on https://web.pulsar-edit.dev/packages/highlight-line I'm guessing your personal accounts access is still the required one

  4. No idea if / how you could switch it over to the organization

  5. If it was switched, you then would of course need to create a new token for the organization, like on a personal account, there is a section in the settings

  6. No idea what permissions it needed anyways, if your token had any specific ones, please let me know, I haven't been able to find anything about it ..

ElectronicsArchiver commented 1 year ago

I'll ask them for more details.

ElectronicsArchiver commented 1 year ago

I asked for more information and TLDR, they added a feature request for their package backend to allow owners of packages to transfer ownership to other account / ORGANIZATIONS.

If this is implemented, you could create a PPA on the org ( with the public_repo and read:org permissions ) so packages could be updated again!

So basically, wait for them to implement it~

richrace commented 1 year ago

I've gone back in time to look how minimap transitioned. It seems so straight forward. I've no joy this morning trying to push a new version. See the "simple" change here: https://github.com/atom-minimap/minimap/commit/fa68337a0d791f8582f7ba0d929965e674de2217#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

I don't know if the ppm is having trouble?

Creating new version failed: The package.json at owner/repo isn't valid. is the error I'm getting.

I've tried with my ppm PAT, my personal ORG PAT as well.

richrace commented 1 year ago

The PAT looks like it has the correct permissions 🤷 I used that same key to login into ppm

Mine: Screenshot 2023-01-07 at 12 18 23

Org: Screenshot 2023-01-07 at 12 18 49

ElectronicsArchiver commented 1 year ago

@richrace Thanks for trying, well they are working on it right now, so maybe let's give them some time and see if it's getting fixed to a point where it won't be a pain anymore ..

At least the org PAT is already set up.