search

Pulsar-Edit-Highlights / line

@Pulsar-Edit package for highlighting the currently selected line.
https://web.pulsar-edit.dev/packages/highlight-line
MIT License
52 stars 16 forks source link

At long last #14

Closed djak250 closed 10 years ago

djak250 commented 10 years ago

I have written this code out at least 4 times, only to delete it some way or another while trying to get it up on github. Wish they made an easier way to contribute to them on atom. Like being able to load packages from different directories. Anywho, I added in another option to have the lines show the top and bottom of a selection/selections. It's disabled by default but can be enabled by the newly added hotkeys. Also added one for the previous pulled stuff I added. Last but not least, I updated the readme with a screenshot, and gave myself a little credit. ;)

richrace commented 10 years ago

Do you know about apm develop? https://atom.io/docs/v0.84.0/contributing#cloning

Having a look at this now.

richrace commented 10 years ago

Ok; a couple of things.

First there I've pushed some changes that fixed a couple of bugs (https://github.com/richrace/highlight-line/commits/line-selected)

Also, in there is a fix which means you don't have to have the underline option selected for this to work. However, when I have "Hide Highlight On Select" enabled, this breaks the lines showing the selection, unless I have the underline enabled.

Second: If I have underline line to off I and I use multiple lines, then I do a selection, I lose my background highlight and I gain the underline highlight. I also lose the background when I have highlight selection underline disabled.

I can have a look later tonight at the these but not sure when.

richrace commented 10 years ago

I also removed the check for showing the underline on selection if underline is selected. I'd rather give the user more options than constrain them.

djak250 commented 10 years ago

This commit fixed the bugs you were seeing as far as I could tell. Give it a try locally and see if it's fixed all the things you were seeing.

richrace commented 10 years ago

Functionality has been added via this merge cbb209ff847c7a6e1ce29e40683ff5b7c2d3984c