search

Pulsar-Edit-Highlights / line

@Pulsar-Edit package for highlighting the currently selected line.
https://web.pulsar-edit.dev/packages/highlight-line
MIT License
52 stars 16 forks source link

Not sure what to make of this #31

Closed karabijavad closed 9 years ago

karabijavad commented 10 years ago

sorry, not sure how to copy paste the stack trace... ;( http://i.imgur.com/0DydYnj.png

/Applications/Atom.app/Contents/Resources/app/src/lines-component.js:343
Uncaught InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('highlight-line-multi-line-[object Object]-bottom') contains HTML space characters, which are not valid in tokens. /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:351module.exports.React.createClass.updateLineNode /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:351boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.appendOrUpdateVisibleLineNodes /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:188boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.updateLines /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:143boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.componentDidUpdate /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:129mixInto.notifyAll /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/CallbackQueue.js:75ON_DOM_READY_QUEUEING.close /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactReconcileTransa…:88Mixin.closeAll /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214Mixin.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155Mixin.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:141mixInto.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:98(anonymous function) /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:176Mixin.closeAll /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214Mixin.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155ReactDefaultBatchingStrategy.batchedUpdates /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactDefaultBatching…:70batchedUpdates /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:113ReactEventListener.dispatchEvent /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactEventListener.js:186module.exports.React.createClass.focus /Applications/Atom.app/Contents/Resources/app/src/input-component.js:56boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.onFocus /Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:860boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295
5Uncaught InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('highlight-line-multi-line-[object Object]-bottom') contains HTML space characters, which are not valid in tokens. /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:351module.exports.React.createClass.updateLineNode /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:351boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.appendOrUpdateVisibleLineNodes /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:188boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.updateLines /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:143boundMethod /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1295module.exports.React.createClass.componentDidUpdate /Applications/Atom.app/Contents/Resources/app/src/lines-component.js:129mixInto.notifyAll /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/CallbackQueue.js:75ON_DOM_READY_QUEUEING.close /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactReconcileTransa…:88Mixin.closeAll /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214Mixin.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155Mixin.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:141mixInto.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:98(anonymous function) /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:176Mixin.closeAll /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214Mixin.perform /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155ReactDefaultBatchingStrategy.batchedUpdates /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactDefaultBatching…:70enqueueUpdate /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:209ReactCompositeComponentMixin.forceUpdate /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeCompon…:1232(anonymous function) /Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:314
richrace commented 10 years ago

Have you tried quiting Atom and reopening?

richrace commented 10 years ago

I think it's something to do with updating from pre 0.9.x be sure to run Update Package Dependencies too.

karabijavad commented 10 years ago

i have tried quitting and reopening, and the problem continues. when i try to run "Update Package Dependencies", unfortunately i get an error "unable to Update Package Dependencies"

ill figure out why thats happening first i guess

richrace commented 10 years ago

What atom version, OS etc.

And have you tried to remove/reinstall?

On 6 Oct 2014, at 22:22, Javad Karabi notifications@github.com wrote:

i have tried quitting and reopening, and the problem continues. when i try to run "Update Package Dependencies", unfortunately i get an error "unable to Update Package Dependencies"

ill figure out why thats happening first i guess

— Reply to this email directly or view it on GitHub.

karabijavad commented 10 years ago

i have tried removing and reinstalling, disabling and reenabling, etc.. os x 10.9.5 atom 0.135

richrace commented 10 years ago

Ok, so it looks like it was trying to a class 'highlight-line-multi-line-[object Object]-bottom' which should be something like 'highlight-line-multi-line-solid-bottom'.

Now I moved to the new config settings.

Old:

'highlight-line':
  'opacity': '30%'
  'underline':
    'solid': true
  'enableUnderline': true

New:

'highlight-line':
  'enableUnderline': true
  'underline': 'dotted'
richrace commented 10 years ago

See if your config file needs updating?

ghost commented 10 years ago

I was having the same issue; uninstalling & reinstalling the plugin seems to have helped.

ghost commented 10 years ago

For what it's worth, I also manually removed the old config from config.cson before reinstalling the plugin.

karabijavad commented 10 years ago

ah, alright i am going to try again, with the config in mind. thank you. will let you know how it turns out

karabijavad commented 10 years ago

err... where is this settings file that contains: 'highlight-line': ...

edit: figured it out! and yes, modifying to the new suggest config did the trick. thank you!

btw, love your plugin

richrace commented 10 years ago

Sweet! Thanks!

I'll leave this open for a bit to make sure other people see it.