search

Pulsar-Edit-Highlights / line

@Pulsar-Edit package for highlighting the currently selected line.
https://web.pulsar-edit.dev/packages/highlight-line
MIT License
52 stars 16 forks source link

Add Hotkeys/Menu for enabling/disabling Background/underline #9

Closed richrace closed 10 years ago

richrace commented 10 years ago

Also corrected spelling for underlineStyleInUse

@sniperbat what do you think of this?

Don't think we need the Enable All now?

sniperbat commented 10 years ago

("enableBackgroundColor" && "enableUnderline" : on ) == ("allEnable" : on) ("enableBackgroundColor" && "enableUnderline" : off ) == ("allEnable" : off) And setting page has plugin "Enable/Disable" button. So, my opinion is that "allEnable" is unnecessary.
We should keeping setting option clear and simple .

I don`t satisfied with underline style checkboxes too. When all of them unchecked, it is means "enableUnderline" off. I will take time to figure out how to make them in the same time, at least one should be checked. Atom provide any other UI controller can be use? Listbox or radiobox should be good choice.

sniperbat commented 10 years ago

By the way, method "updateSetting" actually just update underline setting, Rename to "updateUnderlineSetting" is better.

richrace commented 10 years ago

I've removed the "Enable All" option and renamed the method.

I've had a look about radio buttons/drop down option but I don't think Atom supports it.

This thread has a little bit of info on it: http://discuss.atom.io/t/package-configuration-settings/2334